Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when renaming input maps in single window mode #86189

Closed
wants to merge 1 commit into from
Closed

Fix crash when renaming input maps in single window mode #86189

wants to merge 1 commit into from

Conversation

jsjtxietian
Copy link
Contributor

Fixes #86165

It already uses call_deferred in another branch, so IMO it's appropriate to add it here.

@Chaosus Chaosus added this to the 4.3 milestone Dec 28, 2023
@AThousandShips AThousandShips requested a review from a team July 12, 2024 14:51
@KoBeWi
Copy link
Member

KoBeWi commented Jul 25, 2024

Superseded by #89346
Although that PR made the other deferred call irrelevant, so you could change it to regular call. But that's no longer a bugfix.

@KoBeWi KoBeWi modified the milestones: 4.3, 4.4 Jul 25, 2024
@jsjtxietian
Copy link
Contributor Author

Sounds like I should close this one since it's no longer crash.

@jsjtxietian jsjtxietian deleted the crash-rename-input-in-single-window branch July 26, 2024 03:22
@AThousandShips AThousandShips removed this from the 4.4 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug crash topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.2 crashes when renaming input maps in single window mode
5 participants
@jsjtxietian @KoBeWi @Chaosus @Sauermann @AThousandShips